Add support for loopback type in nmcli module #7515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
felixfontein
added
check-before-release
ansibullbot
removed
ci_verified
|
If nobody objects I'll merge this in ~a week. |
felixfontein
removed
the
check-before-release
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #7566 🤖 @patchback |
|
@haddystuff thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
* add support for loopback devices * add support for loopback devices * fix yamllint issue in changelog fragment * Fix yamlint warning and add note about new connectin type in docs * change order of lines in documentation so they are sorted (cherry picked from commit 5147c49)
felixfontein
pushed a commit
that referenced
this pull request
Nov 22, 2023
…in nmcli module (#7566) Add support for loopback type in nmcli module (#7515) * add support for loopback devices * add support for loopback devices * fix yamllint issue in changelog fragment * Fix yamlint warning and add note about new connectin type in docs * change order of lines in documentation so they are sorted (cherry picked from commit 5147c49) Co-authored-by: Alex Groshev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds support for device type
loopbackin nmcli module, as it was requested in #6572ISSUE TYPE
COMPONENT NAME
plugins/modules/nmcli.py
ADDITIONAL INFORMATION
With new devices type you should be able to add new ip addresses and dns entries to lo interface. There no way to change mtu since loopback connection doesn't have
802-3-ethernet.mtuparameter yet.